Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-23825: integrated the tracker via a Response Event #2

Merged
merged 6 commits into from Jan 5, 2015

Conversation

bdunogier
Copy link
Member

EZP-23825
Status: ready for review

Adds a ResponseListener that adds the tracker before the </body> tag.

TODO

  • Test if TrackingSettings.AutomaticTracking is enabled (later)
  • Inject legacy settings into the listener
  • Document (in README.md)
  • Test listener
  • Test factory

@bdunogier bdunogier force-pushed the EZP-23825-tracker_integration branch 2 times, most recently from c250824 to ca3ff44 Compare December 20, 2014 12:48
@andrerom
Copy link
Contributor

Ok, so we add it in event instead of documenting how to add it in templates basically. Any pitfalls with this? Will it fail in some cases? Like add it if a REST api has a tag called body?

@bdunogier
Copy link
Member Author

Note that it is how it was done in the legacy one (via a response filter).

It also prevents maintainers from having the installation_id in two places. But yes, there might be edge cases such as the one you describe.

Maybe we could also test the Response content-type for text/html ?

@andrerom
Copy link
Contributor

+1

@lolautruche
Copy link

+1

bdunogier added a commit that referenced this pull request Jan 5, 2015
EZP-23825: integrated the tracker via a Response Event
@bdunogier bdunogier merged commit b37c6f4 into master Jan 5, 2015
@bdunogier bdunogier deleted the EZP-23825-tracker_integration branch January 5, 2015 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants