Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

EZP-23147: As a developer, I want to be able to write plugins for the apps #100

Merged
merged 4 commits into from Jul 28, 2014

Conversation

dpobel
Copy link
Contributor

@dpobel dpobel commented Jul 23, 2014

JIRA: https://jira.ez.no/browse/EZP-23147

Description

This PR is a follow up of #98 (EZP-23012) / #99 which allows the developer to write plugins for the applications provided by the PlatformUIBundle. Actually, it is more about refactoring existing code into plugins for the app which has the benefits of dividing the currently fat application into smaller components.

Like the plugins for the views, there's no particular class to extend to write a plugin for the app (except the YUI Plugin Base class of course). The app plugins added in this PR mostly deal with side tasks related to the application but that don't really belong to the application responsibility. In addition, a typical app plugin would add some routes and views to the application.

Note: this PR is done against the topic branch of #99.

Tasks

  • Inject the registered plugins in the app
  • Refactor some app sub part as plugins
    • Handlebars partial registration
    • Handlebars helpers registration
    • DOM state handling (minimized discovery bar, navigation mode, ...)
    • Dynamic app extension (like the admin part) ? more thinking is needed on that topic, will maybe be handled later

Tests

manual + unit tests

@dpobel dpobel changed the title [WIP] EZP-23147: As a developer, I want to be able to write plugins for the apps EZP-23147: As a developer, I want to be able to write plugins for the apps Jul 25, 2014
@dpobel
Copy link
Contributor Author

dpobel commented Jul 25, 2014

Ready for review

@dpobel dpobel mentioned this pull request Jul 25, 2014
5 tasks
@bdunogier
Copy link
Member

+0

* For full copyright and license information view LICENSE file distributed with this source code.
*/
YUI.add('ez-domstateplugin', function (Y) {
"user strict";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@sunpietro
Copy link
Contributor

Except some typos. +1

dpobel added a commit that referenced this pull request Jul 28, 2014
EZP-23147: As a developer, I want to be able to write plugins for the apps
@dpobel dpobel merged commit 182bdba into ezp-23147_plugin_views Jul 28, 2014
@dpobel dpobel deleted the ezp-23147_plugin_app branch July 28, 2014 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants