Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Integer BDD Scenarios #234

Merged
merged 3 commits into from Sep 10, 2015
Merged

Conversation

miguelcleverti
Copy link

Following up the integer BDD scenarios form dropped PR #211

Todo:

  • Implementation

@andrerom andrerom mentioned this pull request May 28, 2015
@pcardiga
Copy link
Contributor

pcardiga commented Jun 2, 2015

ping @bdunogier, @dpobel, @andrerom

Scenario: The label of an mandatory integer field of a Content must be marked as mandatory
Given a Content Type with a required "integer" with field definition name "Quantity" exists
When I create a content of this type
Then the "Quantity" field should be marked as mandatory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we call it mandatory, or do we call it required?

@andrerom andrerom added the BDD label Jun 9, 2015
@pcardiga
Copy link
Contributor

ping @bdunogier, @andrerom

@andrerom
Copy link
Contributor

andrerom commented Jul 9, 2015

+1

But for other field types we don't need to test everything, it is cool that we do it on one to be able to test FieldType features in general as well, but as said in #243 (comment) we should right now focus on generic use cases to cover all features widely, as opposed to deeply and build up backlog of what to do next to have deeper coverage.

Any idea why this fails btw?

@bdunogier
Copy link
Member

+1

@miguelcleverti
Copy link
Author

@andrerom can this be merged?

@andrerom
Copy link
Contributor

andrerom commented Sep 8, 2015

According to todo implement is not done, if you mean it is ready to be merged there should not be a open sub task on the PR ;)

@miguelcleverti
Copy link
Author

@andrerom my mistake the implementation has been merged for some time now.

andrerom added a commit that referenced this pull request Sep 10, 2015
@andrerom andrerom merged commit c707663 into ezsystems:master Sep 10, 2015
@andrerom
Copy link
Contributor

+1 :)

@miguelcleverti miguelcleverti deleted the IntegerBDDScenarios branch November 26, 2015 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 participants