Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Fix EZP-25048: set fallback languageCode if it is not passed in the request #424

Merged
merged 1 commit into from Nov 10, 2015
Merged

Fix EZP-25048: set fallback languageCode if it is not passed in the request #424

merged 1 commit into from Nov 10, 2015

Conversation

mhyndle
Copy link
Contributor

@mhyndle mhyndle commented Nov 4, 2015

Jira: https://jira.ez.no/browse/EZP-25048

Description

When creating the content inside another newly created content the languageCode is not passed in the request so languageCode for content edit view service is empty - this happends in eZ Studio.
This PR solves it by setting the fallback to the mainLanguageCode of the content if languageCode param is not passed in the request.

Tests

manual + unit tests

@dpobel
Copy link
Contributor

dpobel commented Nov 6, 2015

The test is failing because the content injected in the test is a plain object while in the code, you have this.get('content').get('mainLanguageCode');

@mhyndle
Copy link
Contributor Author

mhyndle commented Nov 9, 2015

Ready for review
ping @dpobel @yannickroger @StephaneDiot

@mhyndle mhyndle changed the title [WIP] Fix EZP-25048: set fallback languageCode if it is not passed in the request Fix EZP-25048: set fallback languageCode if it is not passed in the request Nov 9, 2015
@dpobel
Copy link
Contributor

dpobel commented Nov 9, 2015

+1

1 similar comment
@StephaneDiot
Copy link
Contributor

+1

mhyndle added a commit that referenced this pull request Nov 10, 2015
…nguage_code

Fix EZP-25048: set fallback languageCode if it is not passed in the request
@mhyndle mhyndle merged commit 19f7447 into ezsystems:master Nov 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants