This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-25248: Be able to empty the Trash #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickroger
force-pushed
the
ezp-25248-empty_trash
branch
3 times, most recently
from
d25c57b
to
0e31f38
Compare
yannickroger
changed the title
|
Ready for reviews ( ping @dpobel @StephaneDiot ) |
| @@ -34,8 +41,11 @@ YUI.add('ez-trashview-tests', function (Y) { | |||
| contentType: this.contentTypeMock | |||
| }]; | |||
|
|
|||
| this.barMock = new RenderedView(); | |||
There was a problem hiding this comment.
it's not really a mock, you'd better call it this.barView. Also, the RenderedView instance sets its rendered to true but this is not checked anywhere AFAICS.
|
besides inline comments, +1 |
|
+1 |
|
I've just realized you forgot to add the changes to Resources/public/fonts/selection.json |
6 tasks
yannickroger
force-pushed
the
ezp-25248-empty_trash
branch
from
0e31f38
to
a8cec96
Compare
yannickroger
force-pushed
the
ezp-25248-empty_trash
branch
from
a8cec96
to
519c89d
Compare
yannickroger
added a commit
that referenced
this pull request
Feb 8, 2016
EZP-25248: Be able to empty the Trash
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://jira.ez.no/browse/EZP-25248
Description
This PR adds a menu on the right of the Trash with a button to empty it.
Tests
Manual and unit tests