This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix EZP-26486: In Firefox, media view doesn't update the video #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickroger
changed the title
andrerom
reviewed
Oct 24, 2016
| return ""; | ||
| } | ||
|
|
||
| return this.get('field').fieldValue.uri + "?t=" + Date.now(); |
There was a problem hiding this comment.
no version number we can add in url instead of always refreshing?
There was a problem hiding this comment.
The version number is not available in this view. But looking for it I found an id that does the trick 😄
Following @dpobel 's advice I modified the URL in the template only.
yannickroger
force-pushed
the
ezp-26486-video_browser_cache_15
branch
from
dc94533
to
098f96b
Compare
yannickroger
changed the title
|
Ready for review @dpobel @StephaneDiot @andrerom |
dpobel
approved these changes
Oct 25, 2016
StephaneDiot
approved these changes
Oct 25, 2016
|
PR approved by QA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://jira.ez.no/browse/EZP-26486
Description
Firefox doesn't update the video if the link doesn't change. So we are adding the id of the video in order to force the refresh.
Example of generated URL:
http://ezp.local/content/download/84/322?id=video/aa5ef523f7825634e10dbacb065c1507.webmTests
Manual and unit tests