Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Fixed CS errors after ezrobot update #824

Merged
merged 3 commits into from Mar 21, 2017
Merged

Fixed CS errors after ezrobot update #824

merged 3 commits into from Mar 21, 2017

Conversation

yannickroger
Copy link
Contributor

@yannickroger yannickroger commented Mar 20, 2017

Title says it all.

TODO

  • jshint
  • php cs fixer

@andrerom
Copy link
Contributor

andrerom commented Mar 20, 2017

As for php-cs-fixer, see email from Vidar on how to fix it, .php_cs can be changed to something like:

return PhpCsFixer\Config::create()
    ->setRules([
        '@Symfony' => true,
        '@Symfony:risky' => true,
        'concat_space' => ['spacing' => 'one'],
        'array_syntax' => false,
        'simplified_null_return' => false,
        'phpdoc_align' => false,
        'phpdoc_separation' => false,
        'phpdoc_to_comment' => false,
        'cast_spaces' => false,
        'blank_line_after_opening_tag' => false,
        'single_blank_line_before_namespace' => false,
        'phpdoc_annotation_without_dot' => false,
        'phpdoc_no_alias_tag' => false,
        'space_after_semicolon' => false,
    ])
    ->setRiskyAllowed(true)
    ->setFinder(
        PhpCsFixer\Finder::create()
            ->in(__DIR__)
            ->exclude([
                'bin/.travis',
                'docs',
                'vendor',
                'Resources/public',
                'Tests/js',
            ])
            ->files()->name('*.php')
    )
;

@yannickroger yannickroger changed the title Fixed jshint errors after jshint update Fixed CS errors after ezrobot update Mar 21, 2017
@yannickroger
Copy link
Contributor Author

Thanks for the input for PHP @andrerom

@yannickroger yannickroger merged commit 75ad794 into 1.7 Mar 21, 2017
@yannickroger yannickroger deleted the jshint_errors branch March 21, 2017 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants