Applied fixes after review

* Updated src/lib/API/Builder/SchemaBuilder.php * Updated src/lib/Database/DbPlatform/PostgreSqlDbPlatform.php * Updated src/lib/Database/DbPlatform/SqliteDbPlatform.php
ezsystems · Mar 5, 2019 · 609f3df · 609f3df
1 parent fc5865f
commit 609f3df
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/lib/API/Builder/SchemaBuilder.php b/src/lib/API/Builder/SchemaBuilder.php
@@ -33,7 +33,7 @@ public function buildSchema(): Schema;
      *
      * @param string $schemaFilePath
      *
-     * @return mixed
+     * @return \Doctrine\DBAL\Schema\Schema
      */
     public function importSchemaFromFile(string $schemaFilePath): Schema;
 }
diff --git a/src/lib/Database/DbPlatform/PostgreSqlDbPlatform.php b/src/lib/Database/DbPlatform/PostgreSqlDbPlatform.php
@@ -41,7 +41,7 @@ public function getCreateSchemaSQL($schemaName)
      *
      * @throws \InvalidArgumentException
      */
-    public function getDropTableSQL($table)
+    public function getDropTableSQL($table): string
     {
         $tableArg = $table;
 

diff --git a/src/lib/Database/DbPlatform/SqliteDbPlatform.php b/src/lib/Database/DbPlatform/SqliteDbPlatform.php
@@ -65,7 +65,7 @@ public function supportsForeignKeyConstraints(): bool
      *
      * {@inheritdoc}
      */
-    public function getDropForeignKeySQL($foreignKey, $table)
+    public function getDropForeignKeySQL($foreignKey, $table): string
     {
         // dropping FKs is not supported by Sqlite
 
@@ -77,7 +77,7 @@ public function getDropForeignKeySQL($foreignKey, $table)
      *
      * {@inheritdoc}
      */
-    public function getCreateForeignKeySQL(ForeignKeyConstraint $foreignKey, $table)
+    public function getCreateForeignKeySQL(ForeignKeyConstraint $foreignKey, $table): string
     {
         return '-- ';
     }