EZP-25409: Make CAPI site access aware #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +71,10 @@ define(["structures/Response", "structures/Request", "structures/CAPIError"], | |||
| } | |||
| } | |||
|
|
|||
| if (null !== this._siteAccess) { | |||
| headers = extend({}, headers, {'X-Siteaccess': this._siteAccess}); | |||
There was a problem hiding this comment.
this seems quite complicated, can't you just write ?
headers['X-Siteaccess'] = this._siteAcess;There was a problem hiding this comment.
also the same operation has to be done in notAuthorizedRequest method below
|
@wizhippo up for it? :) |
| @@ -11,11 +11,13 @@ define(["structures/Response", "structures/Request", "structures/CAPIError"], | |||
| * @param endPointUrl {String} url to REST root | |||
| * @param authenticationAgent {object} Instance of one of the AuthAgents (e.g. SessionAuthAgent, HttpBasicAuthAgent) | |||
| * @param connectionFactory {ConnectionFeatureFactory} the factory which is choosing compatible connection from connections list | |||
| * @param siteAccess {String|Null} SiteAccess to use for requests | |||
There was a problem hiding this comment.
you should mark the parameter as optional ie
@param [siteAccess] {String} SiteAccess to use for requests
|
besides the last 2 inline comments, +1 |
|
@dpobel thanks for the review |
|
+1 |
1 similar comment
|
+1 |
dpobel
added a commit
that referenced
this pull request
Feb 24, 2016
EZP-25409: Make CAPI site access aware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-25409
This allows the siteacces to be passed as an option to CAPI