[Travis] Fix tests, move to newer version of phpunit #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
reviewed
Mar 1, 2019
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| use EzSystems\EzSupportToolsBundle\SystemInfo\Collector\ConfigurationSymfonyKernelSystemInfoCollector; | |||
| use EzSystems\EzSupportToolsBundle\SystemInfo\Value\SymfonyKernelSystemInfo; | |||
| use PHPUnit_Framework_TestCase; | |||
| use PHPUnit\Framework\TestCase as PHPUnit_Framework_TestCase; | |||
There was a problem hiding this comment.
Wouldn't it be simpler to change extends PHPUnit_Framework_TestCase into extends TestCase? Just one line more ;)
glye
approved these changes
Mar 1, 2019
alongosz
approved these changes
Mar 1, 2019
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup here too in order to align with other repos.