Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32097: Expose EzSystemInfo in Admin UI and SystemInfoDumpCommand #69

Merged
merged 10 commits into from
Nov 3, 2020

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Oct 21, 2020

JIRA: https://jira.ez.no/browse/EZP-32097

Excerpt from the public ticket:

After moving system information related components entirely to ez-support-tools there is an easy way to extend tabs by tagging missing support_tools.system_info.collector.system.ez collector. Thanks to that we can expose DXP Platform information (version, naming, stability, etc) both in the UI and the command. That enables us to improve system version detection on the support portal.

Data gathered by the collector is available via ibexa option:

php bin/console ez-support-tools:dump-info ibexa

TODO:

  • added EOL and EOM dates to IbexaSystemInfo.php

Zrzut ekranu 2020-10-21 o 16 16 14

@lserwatka
Copy link
Member

You have show dates when support expire.

@andrerom
Copy link
Contributor

andrerom commented Oct 21, 2020

You have show dates when support expire.

We can't yet show if customer has an active subscription here (aka if they have Support or not), that is later step where we fetch such info from API on updates/support.ibexa.co.

But indeed we should show the dates for EOM and EOL here, and provide a link to read more about it on https://support.ibexa.co/Public/Service-Life

@konradoboza Feel free to propose new params on value object in order to pass this from collector to template, maybe opt for Date objects as type?

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for changes to names and labels

@SylvainGuittard Maybe you should also give some input on naming of things here, especially regarding Enterprise vs DXP, maybe that should be left for 3.3

@lserwatka
Copy link
Member

Ca we name this tab like "My Ibexa", "My Software", "My Installation" or something like this?

@andrerom
Copy link
Contributor

Ca we name this tab like "My Ibexa", "My Software", "My Installation" or something like this?

Yes indeed, I so far opted to propose just Ibexa as I realized this would be about our product right now, and in the future also info on subscription and services from us for instance. So My Ibexa fits well also.

@lserwatka
Copy link
Member

I like "My Ibexa". Let's go for it.

@konradoboza konradoboza changed the title EZP-32097: Expose EzSystemInfo in Admin UI and SystemInfoDumpCommand [WIP] EZP-32097: Expose EzSystemInfo in Admin UI and SystemInfoDumpCommand Oct 23, 2020
@konradoboza
Copy link
Member Author

konradoboza commented Oct 24, 2020

Code review remarks applied, did some refactoring, corrected nitpicks, and tweaked tab's design - updated screenshot below. @dew326 feel free to suggest design adjustments if needed.

Zrzut ekranu 2020-10-24 o 16 34 13

@konradoboza konradoboza changed the title [WIP] EZP-32097: Expose EzSystemInfo in Admin UI and SystemInfoDumpCommand EZP-32097: Expose EzSystemInfo in Admin UI and SystemInfoDumpCommand Oct 24, 2020
@konradoboza
Copy link
Member Author

All code review remarks applied, please re-review @andrerom @dew326 @lserwatka @mateuszdebinski.

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We can iterate on this later to provide further links to OSS version for instance to read more on what you are missing out from.

@micszo micszo self-assigned this Oct 30, 2020
@konradoboza konradoboza changed the base branch from master to 2.2 November 2, 2020 12:05
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on v3.2.0 with branch with OSS, EE & EC.

@micszo micszo removed their assignment Nov 2, 2020
@konradoboza
Copy link
Member Author

Updated PR according to @SylvainGuittard suggestions passed via Slack, updated tab shown below:

Zrzut ekranu 2020-11-3 o 08 58 33

@SylvainGuittard
Copy link

Excellent! Thanks @konradoboza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants