Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32243: Exposed repository object counts in database tab #76

Merged
merged 11 commits into from
Dec 31, 2020
Merged

EZP-32243: Exposed repository object counts in database tab #76

merged 11 commits into from
Dec 31, 2020

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Dec 17, 2020 •
edited
Loading

JIRA: https://issues.ibexa.co/browse/EZP-32243

Excerpt from the ticket:

The database tab should also contain information about current repository metrics like:

  • published content objects count,
  • users count,
  • drafts count,
  • content types count.

To be expanded further in the next steps, further ideas can be found in https://github.com/ezsystems/support-site/issues/108.

Note: the failing job is related to not updated Behat tests, I will do a followup once this PR gets accepted.

Zrzut ekranu 2020-12-22 o 14 50 09

Related PR:
ezsystems/ezplatform-admin-ui#1681

  • adapt existing unit tests,
  • followup in AdminUI for Behat scenarios.

@konradoboza konradoboza force-pushed the ezp-32243-repository-statistics-section branch from 68a1b7d to 8573678 Compare December 17, 2020 13:04
@konradoboza konradoboza marked this pull request as ready for review December 21, 2020 09:08
@andrerom
Copy link
Contributor

@mnocon @micszo Should maybe the Behat spec features be moved into this package instead?

@mnocon
Copy link
Member

mnocon commented Dec 21, 2020

@andrerom yes, I plan to do that in January once 3.3 is released (I have a refactor started that allows us to decouple tests easily).

@konradoboza konradoboza changed the title EZP-32243: Exposed repository object counts in database tab [WIP] EZP-32243: Exposed repository object counts in database tab Dec 22, 2020
alongosz
alongosz requested changes Dec 22, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review:

src/bundle/Resources/config/services.yaml Outdated Show resolved Hide resolved
src/bundle/Resources/config/services.yaml Outdated Show resolved Hide resolved
src/bundle/SystemInfo/Value/RepositorySystemInfo.php Outdated Show resolved Hide resolved
src/bundle/Tests/SystemInfo/Collector/RepositorySystemInfoCollectorTest.php Outdated Show resolved Hide resolved
src/lib/Storage/DoctrineGateway.php Outdated Show resolved Hide resolved
@konradoboza konradoboza changed the title [WIP] EZP-32243: Exposed repository object counts in database tab EZP-32243: Exposed repository object counts in database tab Dec 22, 2020
@konradoboza
Copy link
Member Author

konradoboza commented Dec 22, 2020 •
edited
Loading

I reworked the current approach by introducing tagged metrics instead of one, generic gateway. Side: the failing job still refers to Behat tests, ref: https://travis-ci.com/github/ezsystems/ez-support-tools/jobs/463901364. Travis lits 🟢 now.

@konradoboza konradoboza mentioned this pull request Dec 23, 2020
Merged
2 tasks
@andrerom
Copy link
Contributor

Review ping @alongosz

@alongosz alongosz self-assigned this Dec 29, 2020
alongosz added a commit that referenced this pull request Dec 29, 2020
@alongosz
Aligned URL list parameter with the changes from #76
4b625d5
@alongosz alongosz force-pushed the ezp-32243-repository-statistics-section branch from 88b73a8 to 02719fe Compare December 29, 2020 19:01
@alongosz alongosz changed the title EZP-32243: Exposed repository object counts in database tab [REBASE REQUIRED] EZP-32243: Exposed repository object counts in database tab Dec 29, 2020
@alongosz alongosz mentioned this pull request Dec 29, 2020
Closed
Steveb-p
Steveb-p reviewed Dec 30, 2020
View reviewed changes
src/bundle/Resources/config/services.yaml Outdated Show resolved Hide resolved
src/bundle/Resources/config/services.yaml Outdated Show resolved Hide resolved
Steveb-p
Steveb-p approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although as discussed with Andrew it requires further changes to be properly user-extendable.

tomaszszopinski
tomaszszopinski approved these changes Dec 31, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP (flex) & Ibexa DXP oss with diff.

konradoboza and others added 11 commits December 31, 2020 12:38
@alongosz
EZP-32243: Exposed repository object counts in database tab
7cea020
@alongosz
[DDD] Fixed naming to hide implementation details
900ea1b
@alongosz
[DI] Renamed 'support_tools.metrics' tag to 'ibexa.system_info.metrics'
700e882
@alongosz
Marked metrics providers as internal
c49a69d
@alongosz
[Tests] Added test coverage for DI configuration of metrics providers
3eac2f7
@alongosz
Refactored Metrics implementations to use common Repository connection
203f739
@alongosz
Refactored AggregateMetricsProvider to rely on ServiceLocator
90e59e9
@alongosz
Refactored Yaml configuration to use const for tag name
0c018cd
@alongosz
[DI] Fixed configuration of common dependency for Metrics
f732ac1
@alongosz @Steveb-p
Passed previous exception when Metrics svc was not found
40a48d2 
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
@alongosz
Marked contracts as internal, to be fine-tuned before exposing as API
85a3e10
@alongosz alongosz force-pushed the ezp-32243-repository-statistics-section branch from 3f5d7ee to 85a3e10 Compare December 31, 2020 11:39
@alongosz alongosz changed the title [REBASE REQUIRED] EZP-32243: Exposed repository object counts in database tab EZP-32243: Exposed repository object counts in database tab Dec 31, 2020
@alongosz alongosz merged commit 42af300 into master Dec 31, 2020
@alongosz alongosz deleted the ezp-32243-repository-statistics-section branch December 31, 2020 11:44
alongosz pushed a commit to ezsystems/ezplatform-admin-ui that referenced this pull request Dec 31, 2020
@konradoboza
[Behat] Aligned tests with changes from ezsystems/ez-support-tools#76 (…
369dcb9 
…#1681)
kacper-wieczorek-ibexa pushed a commit that referenced this pull request Sep 24, 2021
@konradoboza @Steveb-p
@alongosz @kacper-wieczorek-ibexa
EZP-32243: Exposed repository object counts in database tab (#76)
aee6393 
Added "Repository" tab in "Admin -> System Info" providing current Repository metrics:
- published content objects count,
- users count,
- drafts count,
- content types count.

* Exposed repository object counts in database tab

* Marked contracts as internal, to be fine-tuned before exposing as API

Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@dew326 dew326 dew326 approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@lserwatka lserwatka Awaiting requested review from lserwatka

Assignees

@alongosz alongosz

Labels
Feature QA approved
Milestone
No milestone
7 participants
@konradoboza @andrerom @mnocon @Steveb-p @alongosz @dew326 @tomaszszopinski