EZP-32307: Fixed check version stability #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
fixed-check-version-stability
branch
from
7cc4877
to
a3e49f1
Compare
alongosz
requested changes
Jan 22, 2021
src/bundle/SystemInfo/Collector/JsonComposerLockSystemInfoCollector.php
Outdated
Show resolved
Hide resolved
ciastektk
force-pushed
the
fixed-check-version-stability
branch
2 times, most recently
from
cbd6312
to
9b2c36a
Compare
ciastektk
force-pushed
the
fixed-check-version-stability
branch
4 times, most recently
from
6664a74
to
3bb8d36
Compare
alongosz
approved these changes
Jan 26, 2021
| $composerCollectorNotFound = new JsonComposerLockSystemInfoCollector(__DIR__ . '/_fixtures/snafu.lock', __DIR__ . '/_fixtures/composer.json'); | ||
| $composerCollectorNotFound = new JsonComposerLockSystemInfoCollector( | ||
| $this->composerInstalledVersions, | ||
| __DIR__ . '/_fixtures/snafu.lock', |
ciastektk
force-pushed
the
fixed-check-version-stability
branch
from
3bb8d36
to
952f490
Compare
ciastektk
changed the title
tomaszszopinski
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.ibexa.co/browse/EZP-32307
This PR provides implemented
VersionStabilityCheckerfor displaying valid version stability. SinceIbexa/website-skeleton(https://github.com/ibexa/website-skeleton/blob/main/composer.json#L6) providesminimum-stabilityset todevall versions are marked as ‘dev’. Now version stability is based onibexa/ossversion because this package is installed for all Ibexa Platform versions. For BC break reason old check based on composer.lock minimum stability is set as callback in case when Ibexa/oss is not found.