Fix EZP-19883: Unable to add a comment as anonymous user with Oracle

ezsystems · Oct 31, 2012 · e172bc4 · e172bc4
1 parent e666f8c
commit e172bc4
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 10 deletions.
diff --git a/packages/ezcomments_extension/ezextension/ezcomments/share/db_schema.dba b/packages/ezcomments_extension/ezextension/ezcomments/share/db_schema.dba
@@ -71,8 +71,7 @@ $schema = array (
       array (
         'length' => 32,
         'type' => 'varchar',
-        'not_null' => '1',
-        'default' => '',
+        'default' => NULL,
       ),
       'status' => 
       array (

diff --git a/packages/ezcomments_extension/ezextension/ezcomments/sql/mysql/mysql.sql b/packages/ezcomments_extension/ezextension/ezcomments/sql/mysql/mysql.sql
@@ -4,7 +4,7 @@ CREATE TABLE IF NOT EXISTS `ezcomment` (
   `created` int(11) NOT NULL,
   `modified` int(11) NOT NULL,
   `user_id` int(11) NOT NULL,
-  `session_key` varchar(32) NOT NULL,
+  `session_key` varchar(32) DEFAULT NULL,
   `ip` varchar(100) NOT NULL,
   `contentobject_id` int(11) NOT NULL,
   `parent_comment_id` int(11) NOT NULL DEFAULT '0',

diff --git a/packages/ezcomments_extension/ezextension/ezcomments/sql/oracle/oracle.sql b/packages/ezcomments_extension/ezextension/ezcomments/sql/oracle/oracle.sql
@@ -4,7 +4,7 @@ CREATE TABLE ezcomment (
     created           integer NOT NULL,
     modified          integer NOT NULL,
     user_id           integer NOT NULL,
-    session_key       varchar2(32) NOT NULL,
+    session_key       varchar2(32) DEFAULT NULL,
     ip                varchar2(100) NOT NULL,
     contentobject_id  integer NOT NULL,
     parent_comment_id integer DEFAULT 0 NOT NULL,
@@ -96,4 +96,4 @@ BEFORE INSERT ON ezcomment_subscription FOR EACH ROW WHEN (new.id IS NULL)
 BEGIN
     SELECT s_comment_subscription.nextval INTO :new.id FROM dual;
 END;
-/
+/
diff --git a/packages/ezcomments_extension/ezextension/ezcomments/sql/postgresql/postgresql.sql b/packages/ezcomments_extension/ezextension/ezcomments/sql/postgresql/postgresql.sql
@@ -71,7 +71,7 @@ CREATE TABLE ezcomment (
     modified integer DEFAULT 0 NOT NULL,
     name character varying(255) DEFAULT ''::character varying NOT NULL,
     parent_comment_id integer DEFAULT 0 NOT NULL,
-    session_key character varying(32) DEFAULT ''::character varying NOT NULL,
+    session_key character varying(32),
     status integer DEFAULT 0 NOT NULL,
     text text NOT NULL,
     title character varying(255),

diff --git a/...ts_extension/ezextension/ezcomments/update/database/mysql/1.5/dbupdate-1.4.0-to-1.5.0.sql b/...ts_extension/ezextension/ezcomments/update/database/mysql/1.5/dbupdate-1.4.0-to-1.5.0.sql
diff --git a/...ts_extension/ezextension/ezcomments/update/database/mysql/5.0/dbupdate-1.4.0-to-5.0.0.sql b/...ts_extension/ezextension/ezcomments/update/database/mysql/5.0/dbupdate-1.4.0-to-5.0.0.sql
@@ -0,0 +1,7 @@
+
+-- See http://issues.ez.no/19418
+ALTER TABLE ezcomment CHANGE COLUMN text text longtext NOT NULL;
+
+-- https://jira.ez.no/browse/EZP-19883
+ALTER TABLE ezcomment CHANGE COLUMN session_key session_key varchar(32) DEFAULT NULL;
+
diff --git a/...s_extension/ezextension/ezcomments/update/database/oracle/5.0/dbupdate-1.4.0-to-5.0.0.sql b/...s_extension/ezextension/ezcomments/update/database/oracle/5.0/dbupdate-1.4.0-to-5.0.0.sql
@@ -0,0 +1,2 @@
+-- https://jira.ez.no/browse/EZP-19883
+ALTER TABLE ezcomment MODIFY session_key NULL;
diff --git a/...tension/ezextension/ezcomments/update/database/postgresql/5.0/dbupdate-1.4.0-to-5.0.0.sql b/...tension/ezextension/ezcomments/update/database/postgresql/5.0/dbupdate-1.4.0-to-5.0.0.sql
@@ -0,0 +1,2 @@
+-- https://jira.ez.no/browse/EZP-19883
+ALTER TABLE ezcomment ALTER COLUMN session_key SET DEFAULT NULL;