Fix EZP-21239: Autocomplete using YUI3 #122
Conversation
| }; | ||
| loader.insert( {}, 'js' ); | ||
| } | ||
| YUI().use('autocomplete', 'autocomplete-highlighters', 'datasource-io','json-parse', function (Y) { |
There was a problem hiding this comment.
instead of explicitly requiring some modules here, I would set them as dependencies of the ezfindautocomplete one. (see second example in http://yuilibrary.com/yui/docs/yui/#yuiadd)
(nitpick: there's also a small CS issue, missing space before 'json-parse')
|
quite ok for a first frontend related PR ;-) |
|
@dpobel 's suggestions have been taking care of. The PR also includes another commit to rename admin2 since it was supposed to be the case since 5.0. |
| }; | ||
| loader.insert( {}, 'js' ); | ||
| } | ||
| YUI().use('ezfindautocomplete', function (Y) { |
There was a problem hiding this comment.
you're already in the ezfindautocommplete module, so you don't need to require it (I'm actually surprised this is working :))
|
besides the inline comment, +1 |
|
I have only two questions. Did you test a case when there are 2 or more search blocks on one page with eZ Flow? Or in admin when autocomplete is enabled for header and in the search result page? |
|
@lserwatka : yes and yes |
|
Big plus one on on getting rid of some yui2 and jquery use 👍 |
yannickroger
deleted the
ezp-21239_upgrade_to_YUI3_autocomplete_for_jap
branch
Description
Link to the issue: https://jira.ez.no/browse/EZP-21239
The autocomplete feature of ezfind doesn't work when using 2 of the 3 japanese alphabets. These alphabets are not supported buy YUI2 autocomplete, so I rewrote the feature using YUI3 autocomplete which supports them.
Screenshots
Admin
eZdemo
eZflow
Test
Manual test using FF, chrome and IE