Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper eZ Find fetches in default admin2 and standard search templates #78

Merged
merged 1 commit into from Dec 13, 2012
Merged

Use proper eZ Find fetches in default admin2 and standard search templates #78

merged 1 commit into from Dec 13, 2012

Conversation

peterkeung
Copy link
Collaborator

Previously, sorting was broken because eZ Find sorting uses different syntax. Regardless, eZ Find search templates should be using eZ Find fetch functions.

…lates. Previously, sorting was broken because eZ Find sorting uses different syntax
@nfrp
Copy link
Contributor

nfrp commented Oct 4, 2012

Agreed and +1.

What do you guys think @dpobel @bdunogier @lolautruche @andrerom @paulborgermans @patrickallaert @crevillo @masev ?

Thanks and keep-up Peter!

@paulborgermans
Copy link
Contributor

Fine for me, although I am wondering if the search should return results sorted by the (ezfind default) relevancy instead of modification date?

@nfrp
Copy link
Contributor

nfrp commented Oct 26, 2012

+1 for relevancy here, indeed.

@peterkeung
Copy link
Collaborator Author

Yes, although for the 2 clients from which this pull request came from, it was very important for them that the default behavior in the Administration Interface was to sort by modified date. Maybe for the front-end we can have it sort by relevance but keep it as modified in the Administration Interface?

@nfrp
Copy link
Contributor

nfrp commented Oct 26, 2012

Ok here to simply introduce the change in fetch function signature, and keep the sort order as was.
The relevancy ranking can be introduced separately indeed.

@harmstyler
Copy link

+1 for merging this commit as is and deciding upon switching to relevancy as the default separately.

nfrp added a commit that referenced this pull request Dec 13, 2012
Use proper eZ Find fetches in default admin2 and standard search templates
@nfrp nfrp merged commit 2ff9d5b into ezsystems:master Dec 13, 2012
@nfrp
Copy link
Contributor

nfrp commented Dec 13, 2012

Merged, thanks!

PS @peterkeung, @harmstyler or @paulborgermans : feel free to introduce the relevancy-based sorting for the front-end, in a separate PR.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants