Move up the publish of draft to prevent publishing draft without policies assigned #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that running policy updates does not add policies. After more in-depth investigation discovered that the
update()
function published the version of role draft that did not have policies assigned. Moving the call to publish function up before adding policies seem to fix this problem for now.In the future, it would be nice to revise addPolicy() to not publish role draft on every new policy added.