Fixed EZP-20029: Refactor XmlText so that input value content is always ...

[patrickallaert]

...validated

Removing Input Converters with Input value objects.
Input\EzXml is internally used by the XmlText\Type in case of XML string
content being given.

[andrerom]

With "Output" out, the name should probably specify to or from info, like Html5ToEzxml or opposite if that is the case.

Alternatively interface could cover both directions, unsure about the naming of the methods though.

[patrickallaert]

While rethinking XmlText, I thought that with the new design, it was more obvious that an XmlText\Converter would convert an XmlText and as such XmlText\Converter\Html5 would simply convert XmlText to Html5.

If that isn't obvious, I will change it, but I don't really have a good alternative since to me XmlText\ConverterTo\Html5 doesn't really solve the problem since it can be interpreted as "Html5 being ConvertedTo XmlText" or the opposite way around as well.

[andrerom]

It is obvious now that I know your reasoning, but it sure was not obvious when I saw this file on it's own.
But clarifying it with more class doc on some of the files in this PR will help more then enough :)

[andrerom]

A bit unsure what Input means now, as Output is not Converter.

( seems like you need to rebase this branch or something, some extra commits are part of the PR, including comments )

[emodric]

@andrerom Happened to me too on my PR and I can't get rid of it, as rebase does not help :/

[andrerom]

Ok, then this needs to be checked closer, since when I merged your PR we got notifications in campfire about lots of commits being pushed (old + existing commits), so there might be something fishy here.

[dpobel]

it's probably my fault :-/ I did a force push this morning by mistake. To fix it, I cherry picked missing commits from Petar... that's why, Petar's commits appear here and in the Edit's pull request... I'm really sorry for this

[emodric]

@andrerom I was referring to the new one #132, but yeah...

Tried two approaches without luck:

1. rebasing original branch and force pushing
2. creating new one on top of current master, cherry-picking my commits and force pushing

[andrerom]

ok, if dp did a force push on master then that explains it, so lets remind of an old rule:

• Never force push against anything but topic branches

[patrickallaert]

To make this PR clean again, I just dit the following:

$ git pull --rebase (while on master branch)
$ git checkout EZP-20029
$ git rebase master
$ git push --force patrickallaert EZP-20029

[emodric]

@patrickallaert Thanks, that did it. I have no idea why step 1 is necessary though :)

[lolautruche]

👍 Looks ok to me.

[andrerom]

+1

[patrickallaert]

PR has been manually merged while adding some documentation.