Fix EZP-20125: Siteaccess matching error when SA name is in the URL #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| $uriElements = '/' . implode( '/', $this->getURIElements() ); | ||
| if ( strpos( $uri, $uriElements ) === 0 ) | ||
| { | ||
| sscanf( $uri, "$uriElements%s", $uri ); |
|
👍 |
1 similar comment
|
+1 |
ViniTou
added a commit
that referenced
this pull request
Feb 23, 2022
* EZP-32259: Replaced "ezplatform" commands namespace with "ibexa" (emit warning) * EZP-32259: Replaced "ezplatform" commands namespace with "ibexa" (rename) * fixup! EZP-32259: Replaced "ezplatform" commands namespace with "ibexa" (emit warning) * fixup! EZP-32259: Replaced "ezplatform" commands namespace with "ibexa" (rename) * fixup! EZP-32259: Replaced "ezplatform" commands namespace with "ibexa" (emit warning) * EZP-32259: Use getDepracatedAliases method for set up alias names * EZP-32259: Fixed const name usage * EZP-31795: Fix for reindex command alias * EZP-31795: Updated examples and messages Co-authored-by: Dawid Parafiński <dawid.parafinski@ez.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue https://jira.ez.no/browse/EZP-20125
Description
URIElement matcher does a str_replace to generate the URI without the siteaccess (and the subdir prefix). As a result, if the URI contains the siteaccess name (and the subdir prefix), the generated URI is wrong.
Tests
manual tests + unit tests