New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-29995: Move CSS files for Sub Items List Module to Admin UI #129
EZP-29995: Move CSS files for Sub Items List Module to Admin UI #129
Conversation
.c-no-items { | ||
padding: 0 calculateRem(32px); | ||
font-style: italic; | ||
color: $ez-color-base-light; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the rest of empty tables we are applying:
font-size: calculateRem(14px);
color: $ez-color-base-dark;
It would be good to have them here too for consistency purposes.
align-items: center; | ||
cursor: pointer; | ||
|
||
&:not(.c-view-switcher-btn--active):hover, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be further shortened to: &:not(&--active):hover
. But I'm not sure if want to do this as it may be less readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep it like this, for better readability.
@sunpietro @lserwatka fyi, this was merged to branch ezp-29994-mfu-move-css-files instead of master (after that branch was merge in #126) |
@micszo do we have a mess here or not? |
From what I learned from @dew326 and @tischsoic base should be set to master and it should be rebased with master (similarly in #130). |
@dew326 @tischsoic could you help with rebase, I would like to clean up this situation here. |
PR to master: #131 |
thank you @dew326 |
https://jira.ez.no/browse/EZP-29995