Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29995: Move CSS files for Sub Items List Module to Admin UI #129

Merged
merged 2 commits into from Jan 15, 2019

Conversation

sunpietro
Copy link
Contributor

.c-no-items {
padding: 0 calculateRem(32px);
font-style: italic;
color: $ez-color-base-light;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the rest of empty tables we are applying:
font-size: calculateRem(14px);
color: $ez-color-base-dark;
It would be good to have them here too for consistency purposes.

@micszo micszo self-assigned this Jan 14, 2019
align-items: center;
cursor: pointer;

&:not(.c-view-switcher-btn--active):hover,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be further shortened to: &:not(&--active):hover. But I'm not sure if want to do this as it may be less readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it like this, for better readability.

@micszo micszo removed their assignment Jan 14, 2019
@lserwatka lserwatka merged commit 80238e2 into ezp-29994-mfu-move-css-files Jan 15, 2019
@micszo
Copy link
Member

micszo commented Jan 15, 2019

@sunpietro @lserwatka fyi, this was merged to branch ezp-29994-mfu-move-css-files instead of master (after that branch was merge in #126)

@lserwatka
Copy link
Member

@micszo do we have a mess here or not?

@micszo
Copy link
Member

micszo commented Jan 15, 2019

From what I learned from @dew326 and @tischsoic base should be set to master and it should be rebased with master (similarly in #130).

@lserwatka
Copy link
Member

@dew326 @tischsoic could you help with rebase, I would like to clean up this situation here.

@dew326
Copy link
Member

dew326 commented Jan 17, 2019

PR to master: #131

@lserwatka
Copy link
Member

thank you @dew326

@sunpietro sunpietro deleted the ezp-29995-sil-move-css-files branch February 8, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants