Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-28727: Edit button from Multi-file upload does not redirect to Edit form #57

Merged
merged 1 commit into from Mar 14, 2018

Conversation

sunpietro
Copy link
Contributor

contentId: this.state.struct.Content._id,
const content = struct.Content;

return window.Routing.generate('ez_content_draft_edit', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be done by edit link but should be sent a form to edit. Should be done like is in SubItemList. // cc @webhdx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :)

@sunpietro sunpietro force-pushed the ezp-28727-fix-mfu-edit-button branch from bf50c0b to d1526ed Compare March 14, 2018 10:07
@sunpietro
Copy link
Contributor Author

ping @dew326

@sunpietro sunpietro closed this Mar 14, 2018
@sunpietro sunpietro reopened this Mar 14, 2018
@mnocon mnocon self-assigned this Mar 14, 2018
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lserwatka lserwatka merged commit 2248d5c into master Mar 14, 2018
@lserwatka lserwatka deleted the ezp-28727-fix-mfu-edit-button branch March 14, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants