Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31542: Added PHP 7.4 support (eZ Platform 2.5) #1343

Merged
merged 6 commits into from Apr 24, 2020
Merged

EZP-31542: Added PHP 7.4 support (eZ Platform 2.5) #1343

merged 6 commits into from Apr 24, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 9, 2020 •
edited

Question Answer
JIRA issue EZP-31542
Bug/Improvement yes
New feature no
Target version 1.5
BC breaks no
Tests pass yes
Doc needed no

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs
Fixed "Notice: Trying to access array offset on value of type null" i…
0bc7170 
…n \EzSystems\EzPlatformAdminUi\Permission\PermissionChecker::flattenArrayOfLimitationsForCurrentUser
@adamwojs
Enabled testing on PHP 7.4
0045bf4
@adamwojs adamwojs self-assigned this Apr 9, 2020
alongosz
alongosz reviewed Apr 20, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is failing (otherwise +1) ;)

@adamwojs
Copy link
Member Author

Travis is failing (otherwise +1) ;)

Dependencies are installed from branches without PHP 7.4 support. I assumed that "Admin-UI tests on Clean P" and "Admin UI tests using different personas" are part of the regression suite. Is is correct @mnocon ?

@mnocon
Copy link
Member

mnocon commented Apr 21, 2020

@adamwojs yep, that's right

@adamwojs adamwojs requested a review from alongosz April 21, 2020 18:48
@mnocon
Copy link
Member

mnocon commented Apr 23, 2020

@adamwojs I'm getting Notice: Trying to access array offset on value of type null when trying to open the "Search" tab in AdminUI. Full error:

Symfony\Component\Debug\Exception\ContextErrorException:
Notice: Trying to access array offset on value of type null

  at vendor/ezsystems/ezplatform-admin-ui/src/bundle/Controller/SearchController.php:106
  at EzSystems\EzPlatformAdminUiBundle\Controller\SearchController->searchAction(object(Request))

Steps:

  1. Login as admin
  2. Go to Content -> Content structure
  3. Click "Search"

BTW @micszo is experiencing the same thing on 3.0

@adamwojs
Copy link
Member Author

@adamwojs I'm getting Notice: Trying to access array offset on value of type null when trying to open the "Search" tab in AdminUI. Full error:

It looks like a related issue. I will check it!

@adamwojs
Fixed "Notice: Trying to access array offset on value of type null" i…
03e0006 
…n \EzSystems\EzPlatformAdminUiBundle\Controller\SearchController::searchAction
@adamwojs adamwojs merged commit 110700d into 1.5 Apr 24, 2020
@adamwojs adamwojs deleted the php74_support_25 branch April 24, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@mnocon mnocon mnocon approved these changes

@ViniTou ViniTou ViniTou approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@michal-myszka michal-myszka Awaiting requested review from michal-myszka

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@adamwojs adamwojs

Labels
Improvement Ready for QA
Milestone
No milestone
4 participants
@adamwojs @mnocon @alongosz @ViniTou