Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31651: Decoupled Search Bundle from AdminUI #1404

Merged
merged 4 commits into from Jun 23, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 17, 2020

Question Answer
Tickets https://jira.ez.no/browse/EZP-31651
Bug fix? no
New feature? no
BC breaks? no, yes, you decide.
Tests pass? yes/no
Doc needed? yes
License GPL-2.0

Desc:

  • adding user_content_type_identifier parameter to view was moved to adminUI, as this is where this param is declared.

  • SearchForm and Data was moved to new bundle, with BC layer of class_alias

  • All form types/data mappers and co. that was needed for search type to run was copied 1:1 to new bundle, as they are to generic to moved them.

  • EzSystems\EzPlatformAdminUi\Search\AbstractPagerContentToDataMapper was moved to EzSystems\EzPlatformAdminUi\Pagination\Mapper\AbstractPagerContentToDataMapper; As it also handles Dashboard I would say it should not be in Search namespace from beginning.

Search Bundle PR

ezsystems/ezplatform-search#3

Green regression build

https://travis-ci.com/github/ezsystems/ezplatform-page-builder/builds/172636991

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

src/lib/Form/Type/Date/DateIntervalType.php Outdated Show resolved Hide resolved
src/lib/Form/Data/Search/SearchData.php Outdated Show resolved Hide resolved
src/lib/QueryType/SearchQueryType.php Show resolved Hide resolved
@ViniTou ViniTou force-pushed the ezp-31651-cutomizable-search branch 2 times, most recently from 730459c to f8d67b1 Compare June 23, 2020 07:26
@ViniTou ViniTou force-pushed the ezp-31651-cutomizable-search branch from f8d67b1 to 2cb46e9 Compare June 23, 2020 09:20
@ViniTou ViniTou merged commit 3c0c662 into master Jun 23, 2020
@ViniTou ViniTou deleted the ezp-31651-cutomizable-search branch June 23, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants