EZP-31680: Added UDW Search language filter #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dew326
reviewed
Jun 23, 2020
| @@ -130,11 +130,14 @@ export const loadAccordionData = ( | |||
| .catch(showErrorNotification); | |||
| }; | |||
|
|
|||
| export const findLocationsBySearchQuery = ({ token, siteaccess, query, limit = QUERY_LIMIT, offset = 0 }, callback) => { | |||
| export const findLocationsBySearchQuery = ({ token, siteaccess, query, limit = QUERY_LIMIT, offset = 0, languageCode = null }, callback) => { | |||
| const useAlwaysAvailable = true; | |||
There was a problem hiding this comment.
I'm no familiar with this option, is this something I would like to change to false in some cases?
There was a problem hiding this comment.
@dew326 I don't think it should be changed for false while searching in UDW, its hard-coded to true in main "Search" module as well.
There was a problem hiding this comment.
"useAlwaysAvailable defaults to true to avoid exceptions on missing translations"
dew326
approved these changes
Jun 23, 2020
micszo
approved these changes
Jun 23, 2020
|
You can merge it up. |
|
Done: 87b37d1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is a direct continuation of ezsystems/ezplatform-admin-ui-modules#286
Related
ezplatform-kernelPR: ezsystems/ezplatform-rest#51Checklist:
$ composer fix-cs)