EZP-31697: Added remove tooltip when removed node is diffrenty than .… #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
reviewed
Jul 3, 2020
| @@ -39,6 +49,10 @@ | |||
| <div class="tooltip-inner ez-tooltip__inner"></div> | |||
| </div>`, | |||
| }); | |||
|
|
|||
| $(tooltipNode).on('inserted.bs.tooltip', (event) => { | |||
There was a problem hiding this comment.
If this is after the tooltip is set it will be undefined on first time the tooltip is added?
GrabowskiM
approved these changes
Jul 3, 2020
| }); | ||
| if (removedNodes.length) { | ||
| removedNodes.forEach((removedNode) => { | ||
| if (removedNode.classList && !removedNode.classList.contains('ez-tooltip')) { |
There was a problem hiding this comment.
is this removedNode.classList needed? classList is DOM property so it should always exist
dew326
approved these changes
Jul 3, 2020
GrabowskiM
approved these changes
Jul 3, 2020
bogusez
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved tooltip removal. Previously the tooltip was removed if any node was deleted and now I delete it when I delete a node other than .ez-tooltip
Checklist:
$ composer fix-cs)