-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32002: Move system information UI to be a part of ez-support-tools #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 but please move
ezplatform-admin-ui/src/lib/Menu/MainMenuBuilder.php
Lines 43 to 48 in 09b7c86
self::ITEM_ADMIN__SYSTEMINFO => [ | |
'route' => 'ezplatform.systeminfo', | |
'extras' => [ | |
'orderNumber' => 10, | |
], | |
], |
kaff
approved these changes
Oct 13, 2020
@adamwojs moving the menu item will be done as a follow-up to unblock this. |
adamwojs
pushed a commit
to adamwojs/ezplatform-admin-ui
that referenced
this pull request
Oct 21, 2020
adamwojs
pushed a commit
that referenced
this pull request
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing process of moving system Information tab related code to the
ez-support-tools
bundle. For now, Behat tests are left untouched after internal sync with QA. Please do not merge until test dependency is removed.Depends on:
ezsystems/ez-support-tools#60
ezsystems/ezplatform#606
Checklist:
ez-support-tools
repository introducing removed code$ composer fix-cs
)