Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32002: Move system information UI to be a part of ez-support-tools #1569

Merged
merged 11 commits into from
Oct 13, 2020

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Oct 7, 2020

Question Answer
Tickets EZP-32002
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Part of the ongoing process of moving system Information tab related code to the ez-support-tools bundle. For now, Behat tests are left untouched after internal sync with QA. Please do not merge until test dependency is removed.

Depends on:
ezsystems/ez-support-tools#60
ezsystems/ezplatform#606

Checklist:

  • create a corresponding PR in the ez-support-tools repository introducing removed code
  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza changed the title EZP-32002: Move system information UI to be a part of ez-support-tools [DO NOT MERGE] EZP-32002: Move system information UI to be a part of ez-support-tools Oct 12, 2020
@konradoboza konradoboza self-assigned this Oct 12, 2020
@konradoboza konradoboza marked this pull request as ready for review October 12, 2020 12:01
@konradoboza konradoboza changed the title [DO NOT MERGE] EZP-32002: Move system information UI to be a part of ez-support-tools EZP-32002: Move system information UI to be a part of ez-support-tools Oct 13, 2020
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but please move

self::ITEM_ADMIN__SYSTEMINFO => [
'route' => 'ezplatform.systeminfo',
'extras' => [
'orderNumber' => 10,
],
],
to support tools as well.

@lserwatka lserwatka merged commit eb5b81f into master Oct 13, 2020
@lserwatka lserwatka deleted the ezp-32002-move-sysinfo-to-support-tools branch October 13, 2020 14:31
@konradoboza
Copy link
Member Author

konradoboza commented Oct 13, 2020

@adamwojs moving the menu item will be done as a follow-up to unblock this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants