Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32157: Added option to choose SA when creating custom alias #1583

Merged
merged 12 commits into from
Nov 12, 2020
Merged

EZP-32157: Added option to choose SA when creating custom alias #1583

merged 12 commits into from
Nov 12, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Oct 13, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-32157
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Choice of Site Access has been added to the custom URL Alias form to help editors with providing a valid path when using Place at site root option when certain Site Access has parameter content.tree_root.location_id defined.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Oct 13, 2020
@barw4 barw4 changed the title EZP-31110: Added option to choose SA when creating custom alias [WIP] EZP-31110: Added option to choose SA when creating custom alias Oct 13, 2020
@barw4 barw4 mentioned this pull request Oct 13, 2020
Closed
4 tasks
@barw4 barw4 changed the title [WIP] EZP-31110: Added option to choose SA when creating custom alias EZP-31110: Added option to choose SA when creating custom alias Oct 14, 2020
alongosz
alongosz requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added via listener instead directly to a form? Don't know much about AdminUI architecture...

src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
src/lib/Form/Data/Content/CustomUrl/CustomUrlAddData.php Outdated Show resolved Hide resolved
src/lib/Form/EventListener/AddSiteAccessFieldBasedOnContentListener.php Outdated Show resolved Hide resolved
@barw4
Copy link
Member Author

barw4 commented Oct 28, 2020

Why was this added via listener instead directly to a form? Don't know much about AdminUI architecture...

@alongosz I guess in order to keep it clean. In this form type there are 4 other listeners working exactly the same.

DominikaK
DominikaK reviewed Oct 28, 2020
View reviewed changes
src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/views/content/tab/url/modal_add_custom_url.html.twig Outdated Show resolved Hide resolved
src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/views/content/tab/url/modal_add_custom_url.html.twig Outdated Show resolved Hide resolved
src/bundle/Resources/views/content/tab/url/modal_add_custom_url.html.twig Outdated Show resolved Hide resolved
src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/content_url.en.xliff Outdated Show resolved Hide resolved
Applied lingual suggestions
397d790 
Co-authored-by: DominikaK <dominika.kurek@ez.no>
@barw4 barw4 requested a review from alongosz October 29, 2020 00:14
@barw4 barw4 requested a review from Steveb-p November 3, 2020 08:36
@micszo micszo self-assigned this Nov 6, 2020
@barw4
Copy link
Member Author

barw4 commented Nov 9, 2020 •
edited
Loading

ping @ezsystems/documentation-team

I think this functionality will benefit from some minor description somewhere (in doc or RN).

@barw4 barw4 requested a review from dew326 November 9, 2020 16:05
@dew326
CS for admin.location.add.custom_url.js
873bfb7 
Co-authored-by: Dariusz Szut <dew326@gmail.com>
@barw4 barw4 requested a review from dew326 November 10, 2020 08:25
@barw4 barw4 changed the title EZP-31110: Added option to choose SA when creating custom alias EZP-32157: Added option to choose SA when creating custom alias Nov 10, 2020
micszo
micszo approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on eZ Platform EE 2.5 with branch.
Moving to Doc to cover the different combinations.

@micszo micszo removed their assignment Nov 12, 2020
@adamwojs adamwojs merged commit 44f2129 into 1.5 Nov 12, 2020
@adamwojs adamwojs deleted the ezp-31110-alias-with-root-location branch November 12, 2020 11:08
@adamwojs
Copy link
Member

Could yuo please merge up changes @barw4 ?

@barw4
Copy link
Member Author

barw4 commented Nov 12, 2020 •
edited
Loading

Merged into:
2.1: 23d4206
2.2: a145968
master: 3fb24a3

@bjko
Copy link

bjko commented Jan 28, 2021

There are issues with a multi repository setup. If you have the same location ids in both repositories the siteaccesschoicer will display all possible siteaccess even if they are stored in the other repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikaK DominikaK DominikaK left review comments

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@webhdx webhdx webhdx approved these changes

@dew326 dew326 dew326 approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@alongosz alongosz Awaiting requested review from alongosz

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@barw4 barw4

Labels
Feature QA approved
Milestone
No milestone