EZP-32105: Deprecated obsolete pagination search limit configuration setting #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmadejski
requested review from
lserwatka,
adamwojs,
mikadamczyk,
Steveb-p and
ViniTou
lserwatka
approved these changes
Oct 27, 2020
Steveb-p
reviewed
Oct 27, 2020
| ->scalarNode('search_limit')->isRequired()->end() | ||
| ->scalarNode('search_limit') | ||
| ->isRequired() | ||
| ->setDeprecated('ezsystems/ezplatform-admin-ui', '2.1', 'The child node "%node%" at path "%path%" is deprecated. Use "search.pagination.limit" instead.') |
There was a problem hiding this comment.
This will trigger an error in Symfony 5.0 installations, because this method was extended in 5.1
EDIT: Well, not really an error (at least on prod), since we will provide additional, undeclared arguments, but the error message will be cryptic at best.
I know it triggers a deprecation notice in 5.1, but our composer files still mark 5.0 as valid.
There was a problem hiding this comment.
Good observation, thanks!
@lserwatka / @adamwojs should I adapt it to make it valid for Symfony 5.0 (as @Steveb-p said it will trigger deprecation notice on Symfony 5.1 though)?
adamwojs
approved these changes
Oct 27, 2020
mikadamczyk
approved these changes
Oct 28, 2020
lserwatka
deleted the
EZP-32105_Deprecated_obsolete_pagination_search_limit_configuration_setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in ezsystems/ezplatform-search#12
Checklist:
$ composer fix-cs)