Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32173: Fixed UDW 'allowed_content_types' configuration #1666

Merged
merged 4 commits into from
Dec 17, 2020
Merged

EZP-32173: Fixed UDW 'allowed_content_types' configuration #1666

merged 4 commits into from
Dec 17, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Dec 10, 2020

Question Answer
Tickets https://issues.ibexa.co/browse/EZP-32173
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

When 'allowed_content_types' was specified in the .yml config it wasn't taken into consideration. This has been fixed in this PR.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Dec 10, 2020
@ViniTou ViniTou requested a review from dew326 December 11, 2020 10:06
@adamwojs
Copy link
Member

@barw4 Unit tests are failing here.

@barw4
Copy link
Member Author

barw4 commented Dec 14, 2020 •
edited
Loading

@barw4 Unit tests are failing here.

@adamwojs Indeed, adapted tests accordingly in 54ceb42.

@micszo micszo self-assigned this Dec 17, 2020
micszo
micszo approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.15 with diff.

@micszo micszo removed their assignment Dec 17, 2020
@lserwatka lserwatka merged commit 14692f7 into 1.5 Dec 17, 2020
@lserwatka lserwatka deleted the ezp-32173-fix-udw-richtext-config branch December 17, 2020 10:47
@lserwatka
Copy link
Member

You can merge it up.

@barw4
Copy link
Member Author

barw4 commented Dec 17, 2020

Merged into:
2.1 - 8b6a5ee
2.2 - bea40eb
master - 8eb0772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattfarinn Nattfarinn Nattfarinn left review comments

@adamwojs adamwojs adamwojs approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@ViniTou ViniTou Awaiting requested review from ViniTou

@dew326 dew326 Awaiting requested review from dew326

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
7 participants
@barw4 @adamwojs @lserwatka @Steveb-p @Nattfarinn @dew326 @micszo