Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-3399: Remove icon hover state on disabled buttons #1668

Merged
merged 1 commit into from
Dec 17, 2020
Merged

EZEE-3399: Remove icon hover state on disabled buttons #1668

merged 1 commit into from
Dec 17, 2020

Conversation

dew326
Copy link
Member

@dew326 dew326 commented Dec 16, 2020

Question Answer
Tickets https://issues.ibexa.co/browse/EZEE-3399
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 added the Bug label Dec 16, 2020
@dew326 dew326 self-assigned this Dec 16, 2020
@micszo micszo self-assigned this Dec 17, 2020
micszo
micszo approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with https://github.com/ibexa/image-editor/pull/9.

@micszo micszo removed their assignment Dec 17, 2020
@lserwatka lserwatka merged commit a3f0f2a into master Dec 17, 2020
@lserwatka lserwatka deleted the make-no-hover-on-disabled branch December 17, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

Assignees

@dew326 dew326

Labels
Bug
Milestone
No milestone
5 participants
@dew326 @GrabowskiM @micszo @lucasOsti @lserwatka