EZP-32248: Retain content tree state #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Dec 22, 2020
| @@ -26,10 +28,46 @@ export default class ContentTree extends Component { | |||
| this.clearDocumentResizingListeners(); | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| this.containerSrollRef.addEventListener('scroll', (event) => { | |||
There was a problem hiding this comment.
Suggested change
| this.containerSrollRef.addEventListener('scroll', (event) => { | |
| this.containerScrollRef.addEventListener('scroll', (event) => { |
| @@ -26,10 +28,46 @@ export default class ContentTree extends Component { | |||
| this.clearDocumentResizingListeners(); | |||
| } | |||
|
|
|||
| componentDidMount() { | |||
| this.containerSrollRef.addEventListener('scroll', (event) => { | |||
| clearTimeout(this.scrollTimeout); | |||
There was a problem hiding this comment.
Suggested change
| clearTimeout(this.scrollTimeout); | |
| window.clearTimeout(this.scrollTimeout); |
To show that this is from window object
| this.containerSrollRef.addEventListener('scroll', (event) => { | ||
| clearTimeout(this.scrollTimeout); | ||
|
|
||
| this.scrollTimeout = setTimeout( |
There was a problem hiding this comment.
Suggested change
| this.scrollTimeout = setTimeout( | |
| this.scrollTimeout = window.setTimeout( |
| document.body.dispatchEvent(new CustomEvent('ez-content-tree-resized')); | ||
| } | ||
|
|
||
| if (this.props.items.length && !this.scrollPositionSet) { |
There was a problem hiding this comment.
Suggested change
| if (this.props.items.length && !this.scrollPositionSet) { | |
| if (this.props.items && this.props.items.length && !this.scrollPositionSet) { |
?
dew326
requested changes
Dec 23, 2020
|
|
||
| saveConfig(id, value) { | ||
| const data = JSON.parse(window.localStorage.getItem('ez-content-tree-state') || '{}'); | ||
| const userId = window.eZ.helpers.user.getId(); |
There was a problem hiding this comment.
I don't think it should be taken from window object. To the content tree userId is passed as a prop. It would be better to keep the consistency of data.
dew326
approved these changes
Dec 23, 2020
lucasOsti
approved these changes
Dec 23, 2020
bogusez
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: