Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32287: Wrong size of a Save tile on the URL management edit page #1693

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/EZP-32287
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Added missing html container .ez-sticky-container

Screenshot from 2021-01-15 14-59-17

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti requested a review from a team January 15, 2021 13:59
@bogusez
Copy link
Contributor

bogusez commented Jan 18, 2021

Please do not marge yet

@bogusez
Copy link
Contributor

bogusez commented Jan 18, 2021

We need PR for 3.2 version as well

@bogusez bogusez self-assigned this Jan 18, 2021
@lucasOsti lucasOsti changed the base branch from master to 2.2 January 18, 2021 10:09
@lucasOsti lucasOsti changed the base branch from 2.2 to master January 18, 2021 10:10
@lserwatka
Copy link
Member

What happened here? Can't we change target brach to 3.2 and rebase?

@bogusez
Copy link
Contributor

bogusez commented Jan 18, 2021

What happened here? Can't we change target brach to 3.2 and rebase?

A new PR to 3.2 has been made by @lucasOsti

@lserwatka
Copy link
Member

@bogusez Ok, so can we merge this one?

@bogusez
Copy link
Contributor

bogusez commented Jan 18, 2021

@bogusez Ok, so can we merge this one?

Yes, we can merge it to master

@lserwatka lserwatka merged commit 6be6901 into ezsystems:master Jan 18, 2021
@bogusez bogusez removed their assignment Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants