Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32308: Passed mandatory Location into LocationLimitation #1699

Merged
merged 3 commits into from
Feb 12, 2021
Merged

EZP-32308: Passed mandatory Location into LocationLimitation #1699

merged 3 commits into from
Feb 12, 2021

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jan 28, 2021 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-32308
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Based on:
ezsystems/ezpublish-kernel#3083
At least one valid Location object is needed to properly solve LocationLimitation (content/edit).

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou changed the base branch from master to 1.5 February 10, 2021 09:06
tomaszszopinski
tomaszszopinski approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5 & v2.5.16 with patch & diff.

@adamwojs adamwojs merged commit 3b1fddd into 1.5 Feb 12, 2021
@adamwojs adamwojs deleted the ezp-32308-location-limitations-2.5 branch February 12, 2021 20:37
@adamwojs
Copy link
Member

Could you please merge up changes @ViniTou?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@alongosz alongosz alongosz approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@adamwojs adamwojs Awaiting requested review from adamwojs

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
5 participants
@ViniTou @adamwojs @Nattfarinn @alongosz @tomaszszopinski