EZEE-3479: As a developer I want to have reusable componenet for charts #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
changed the title
lucasOsti
changed the title
lucasOsti
changed the title
dew326
requested changes
Feb 10, 2021
| getScalesYAxesOption() { | ||
| let YAxes = []; | ||
|
|
||
| if (this.type === 'line') { |
There was a problem hiding this comment.
this.type this is never set in this base class and this class definitely should not know what are the values of this properties
lucasOsti
changed the title
lucasOsti
force-pushed
the
EZEE-3479-As-a-developer-I-want-to-have-reusable-componenet-for-charts
branch
from
f35f17f
to
3a81701
Compare
GrabowskiM
requested changes
Feb 10, 2021
| checkbox.style.backgroundColor = checkedColor; | ||
| checkbox.style.borderColor = checkedColor; | ||
| } else { | ||
| checkbox.style.backgroundColor = '#fff'; |
There was a problem hiding this comment.
I would put colors to constants at the beginning of file
dew326
requested changes
Feb 11, 2021
|
|
||
| render() { | ||
| this.chart = new Chart(this.canvas.getContext('2d'), { | ||
| type: this.getType(), |
There was a problem hiding this comment.
getType is not defined in this class
| options: { | ||
| responsive: true, | ||
| maintainAspectRatio: false, | ||
| layout: this.layoutOptions(), |
There was a problem hiding this comment.
Suggested change
| layout: this.layoutOptions(), | |
| layout: this.getLayoutOptions(), |
?
| chartNode.classList[chartMethod]('ez-chart--no-data'); | ||
| }, | ||
| }, | ||
| scales: this.scaleOptions(), |
There was a problem hiding this comment.
Suggested change
| scales: this.scaleOptions(), | |
| scales: this.getScaleOptions(), |
?
| }; | ||
| } | ||
|
|
||
| legendOptions(chart) { |
There was a problem hiding this comment.
Suggested change
| legendOptions(chart) { | |
| getLegendOptions(chart) { |
?
GrabowskiM
approved these changes
Feb 11, 2021
dew326
approved these changes
Feb 11, 2021
tomaszszopinski
approved these changes
Feb 17, 2021
lucasOsti
added a commit
that referenced
this pull request
Feb 26, 2021
adamwojs
pushed a commit
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reusable component for chart
Checklist:
$ composer fix-cs)