EZEE-3484: Create translated draft before edit if autosave is enabled #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattfarinn
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
damianz5,
alongosz,
ciastektk,
webhdx,
ViniTou and
a team
Nattfarinn
force-pushed
the
ezee-3484-translate-autosave
branch
from
3c28c9e
to
e60f630
Compare
Steveb-p
reviewed
Feb 26, 2021
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
Steveb-p
approved these changes
Feb 26, 2021
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
ViniTou
approved these changes
Feb 26, 2021
|
@Nattfarinn Code style needs to be fixed here |
adamwojs
requested changes
Mar 4, 2021
| ]) | ||
| ); | ||
| } | ||
|
|
||
| $event->setResponse($response); | ||
| } | ||
|
|
||
| public function translate(ContentProxyTranslateEvent $event): void |
There was a problem hiding this comment.
We need test coverage for this code. See #1714 (comment)
Co-authored-by: Adam Wójs <adam@wojs.pl>
tomaszszopinski
approved these changes
Mar 5, 2021
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)