Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZEE-3486: Added AllowedContentTypes to default config as it was overridden by default empty value #1717

Merged
merged 4 commits into from
Mar 8, 2021

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 2, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/EZEE-3486
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This had nothing to do with unsplash, or dam connector.
From what I understand allowed CTs were passed here ezplatform-admin-ui/src/bundle/Resources/public/js/scripts/fieldType/ezimageasset.js L178

            ReactDOM.render(
                React.createElement(eZ.modules.UniversalDiscovery, {
                    onConfirm,
                    onCancel,
                    title,
                    allowedContentTypes: [imageAssetMapping['contentTypeIdentifier']],
                    ...config,
                }),
                udwContainer
            );

But since that key now exist with default value, this part is overridden by it.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs
Copy link
Member

adamwojs commented Mar 2, 2021

@ViniTou Code style needs to be fixed here.

@ViniTou ViniTou force-pushed the ezee-3486-asset-select-from-repository branch from 1596b9e to 66822f2 Compare March 2, 2021 11:30
…ontentTypes.php

Co-authored-by: Adam Wójs <adam@wojs.pl>
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 3.2.5-dev & 3.3.2-dev with patch.

@lserwatka lserwatka merged commit 08ae795 into 2.2 Mar 8, 2021
@lserwatka lserwatka deleted the ezee-3486-asset-select-from-repository branch March 8, 2021 13:01
@lserwatka
Copy link
Member

Could you merge it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants