EZP-31632: Floating table toolbar #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Mar 11, 2021
src/bundle/Resources/public/js/alloyeditor/src/toolbars/config/base-table.js
Outdated
Show resolved
Hide resolved
dew326
reviewed
Mar 11, 2021
src/bundle/Resources/public/js/alloyeditor/src/toolbars/config/base-table.js
Show resolved
Hide resolved
dew326
reviewed
Mar 11, 2021
src/bundle/Resources/public/js/alloyeditor/src/toolbars/config/base-table.js
Outdated
Show resolved
Hide resolved
dew326
approved these changes
Mar 11, 2021
lucasOsti
approved these changes
Mar 15, 2021
GrabowskiM
approved these changes
Mar 15, 2021
micszo
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
QA Approved on eZ Platform EE v2.5.17 with diff.
Also checked https://issues.ibexa.co/browse/EZP-32006 and https://issues.ibexa.co/browse/EZP-32187 (does not affect 2.5).
Performed sanities for block and inline custom tags.
|
Could you merge it up? |
|
Done, merge up to 2.2, 2.3 and master |
lucasOsti
pushed a commit
to lucasOsti/ezplatform-admin-ui
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is port from this PR: ezsystems/ezplatform-richtext#148
Checklist:
$ composer fix-cs)