Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32395: Fixed location visibility due to kept BC #1733

Merged
merged 1 commit into from
Apr 7, 2021
Merged

EZP-32395: Fixed location visibility due to kept BC #1733

merged 1 commit into from
Apr 7, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Apr 7, 2021 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/EZP-32395
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Fixes BC as not keyword was missing. Direct continuation of #1725.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Apr 7, 2021
@barw4 barw4 requested a review from adamwojs April 7, 2021 09:19
Steveb-p
Steveb-p approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a BC break though. It's a plain 🐛 :P

@barw4 barw4 changed the title EZP-32395: Fixed location visibility BC break EZP-32395: Fixed location visibility due to kept BC Apr 7, 2021
@barw4
Copy link
Member Author

barw4 commented Apr 7, 2021

Not a BC break though. It's a plain 🐛 :P

Indeed, fixed the description

@adamwojs adamwojs merged commit 3c0be92 into 1.5 Apr 7, 2021
@adamwojs adamwojs deleted the fix-location-visibility-bc branch April 7, 2021 13:03
@adamwojs
Copy link
Member

adamwojs commented Apr 7, 2021

Could you please merge up changes @barw4?

@barw4
Copy link
Member Author

barw4 commented Apr 7, 2021 •
edited
Loading

Merged into
2.2 - 6d23cb4
2.3 - 6843db8
master - 08b53e8

lucasOsti pushed a commit to lucasOsti/ezplatform-admin-ui that referenced this pull request Apr 28, 2021
@barw4 @lucasOsti
EZP-32395: Fixed location visibility due to kept BC (ezsystems#1733)
42c0291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@barw4 barw4

Labels
Bug Ready for MERGE
Milestone
No milestone
3 participants
@barw4 @adamwojs @Steveb-p