IBX-159: Added pagination in locations tab #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
reviewed
Apr 9, 2021
ViniTou
reviewed
Apr 9, 2021
webhdx
requested changes
Apr 9, 2021
Steveb-p
approved these changes
Apr 9, 2021
alongosz
requested changes
Apr 9, 2021
ViniTou
reviewed
Apr 12, 2021
ViniTou
approved these changes
Apr 12, 2021
adamwojs
approved these changes
Apr 13, 2021
webhdx
approved these changes
Apr 13, 2021
alongosz
approved these changes
Apr 13, 2021
micszo
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
QA Approved on eZ Platform EE 2.5 with diff.
Side, while at it stumbled upon 10 year old issue with sending to trash of times with multiple locations: https://issues.ibexa.co/browse/EZP-18871.
|
Could you merge it up? |
lucasOsti
pushed a commit
to lucasOsti/ezplatform-admin-ui
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)