IBX-183: Fixed accessing Tabs with spaces and special characters #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Apr 15, 2021
webhdx
approved these changes
Apr 15, 2021
mateuszbieniek
approved these changes
Apr 15, 2021
|
Can we expect other special chars than space to blow up? I dunno, |
|
Indeed, the error remains for values like: |
alongosz
changed the title
alongosz
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
@konradoboza PR title should summarize the essence of the changes for the current context (package), formed in past simple. Fixed that for you.
|
Your kindness is beyond my imagination @alongosz, much appreciated. 😄 |
ViniTou
approved these changes
Apr 15, 2021
|
Works good now. |
bogusez
approved these changes
Apr 16, 2021
|
Could you merge it up? |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab ids coming from custom category names containing spaces make tabs inaccessible. The idea is to sanitize them by replacing spaces with hyphens to match current
item-notation.Checklist:
$ composer fix-cs)