Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-22: Added danger font color #1739

Merged
merged 2 commits into from
May 17, 2021

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Apr 19, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-22
Related to https://github.com/ezsystems/ezplatform-page-builder/pull/740
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti changed the title Added danger font color IBX-22: Added danger font color Apr 19, 2021
@dew326 dew326 requested a review from tischsoic April 19, 2021 12:27
@@ -28,6 +28,7 @@ $ibexa-color-font: #131c26;
$ibexa-color-font-light: #fff;
$ibexa-color-font-pale: #878b90;
$ibexa-color-font-black: #222222;
$ibexa-color-font-danger:#d92d42;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really sorry, but... :D

Suggested change
$ibexa-color-font-danger:#d92d42;
$ibexa-color-font-danger: #d92d42;

@lucasOsti lucasOsti marked this pull request as draft April 19, 2021 13:54
@lucasOsti lucasOsti marked this pull request as ready for review April 19, 2021 13:54
@lucasOsti lucasOsti changed the base branch from master to 2.3 May 14, 2021 07:13
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa Commerce 3.3.2-dev with diff.

@adamwojs adamwojs merged commit c6245ee into ezsystems:2.3 May 17, 2021
@adamwojs
Copy link
Member

Could you please merge up changes @lucasOsti?

@ViniTou
Copy link
Contributor

ViniTou commented May 17, 2021

I had merged it up as it dependency for page-builder & page-fieldtype PRs.

ViniTou pushed a commit that referenced this pull request Jun 21, 2021
ViniTou pushed a commit that referenced this pull request Jun 21, 2021
ViniTou added a commit that referenced this pull request Jun 25, 2021
(cherry picked from commit c6245ee)

Co-authored-by: Łukasz Ostafin <ostafin.lucas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants