EZP-31602: Moving to trash confirmation modal is not updated after sub-items bulk move #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b-items bulk move
2 tasks
dew326
requested changes
Apr 27, 2021
| @@ -7,6 +7,7 @@ | |||
| const sortContainer = doc.querySelector('[data-sort-field][data-sort-order]'); | |||
| const sortField = sortContainer.getAttribute('data-sort-field'); | |||
| const sortOrder = sortContainer.getAttribute('data-sort-order'); | |||
| const contentName = doc.querySelector('.ez-sil').dataset.contentName; | |||
There was a problem hiding this comment.
Don't think this should be in the subitems div. This should be stored in the modal itself to be independent.
GrabowskiM
requested changes
Apr 27, 2021
|
|
||
| modalBody.innerHTML = message; | ||
| modalSendToTrashButton.toggleAttribute('disabled', false); | ||
| modalSendToTrashButton.classList.toggle('disabled', false); |
There was a problem hiding this comment.
remove instead of toggle
| ); | ||
|
|
||
| modalBody.innerHTML = message; | ||
| modalSendToTrashButton.toggleAttribute('disabled', false); |
There was a problem hiding this comment.
removeattribute instead of toggleattribute
tischsoic
requested changes
Apr 28, 2021
| @@ -118,6 +118,36 @@ | |||
|
|
|||
| $(SELECTOR_MODAL_BULK_ACTION_FAIL).modal('show'); | |||
| }; | |||
| const refreshTrashModal = (event) => { | |||
There was a problem hiding this comment.
I wonder, maybe we should put these changes here:
https://github.com/ezsystems/ezplatform-admin-ui/blob/1.5/src/bundle/Resources/public/js/scripts/admin.trash.js
tischsoic
approved these changes
Apr 28, 2021
GrabowskiM
approved these changes
Apr 28, 2021
dew326
approved these changes
Apr 29, 2021
kacper-wieczorek-ibexa
approved these changes
May 5, 2021
|
@mnocon same here, it is failing. |
|
You can merge it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)