Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-241: Subitems - priority buttons hidden behind most-right column #1753

Merged
merged 1 commit into from
May 17, 2021
Merged

IBX-241: Subitems - priority buttons hidden behind most-right column #1753

merged 1 commit into from
May 17, 2021

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-241
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@micszo
Copy link
Member

micszo commented May 13, 2021

Hi. Should base be master or 2.3? JIRA ticket mentions 3.3.0.
Or even further - is 3.2 affected?

@lucasOsti lucasOsti changed the base branch from master to 2.3 May 13, 2021 12:55
@lucasOsti lucasOsti changed the base branch from 2.3 to master May 13, 2021 12:55
@lucasOsti lucasOsti force-pushed the IBX-241-Subitems-priority-buttons-hidden-behind-most-right-column branch from a2f8132 to 2acbee9 Compare May 13, 2021 13:03
@lucasOsti lucasOsti changed the base branch from master to 2.3 May 13, 2021 13:04
@piotrbisaga piotrbisaga self-assigned this May 14, 2021
@piotrbisaga
Copy link
Contributor

@lucasOsti I reproduced it on 3.2, could you please change base to 2.2?

@lucasOsti lucasOsti changed the base branch from 2.3 to 2.2 May 14, 2021 10:09
@lucasOsti lucasOsti changed the base branch from 2.2 to 2.3 May 14, 2021 10:10
@lucasOsti lucasOsti changed the base branch from 2.3 to 2.2 May 14, 2021 11:25
@lucasOsti lucasOsti changed the base branch from 2.2 to 2.3 May 14, 2021 11:26
@lucasOsti lucasOsti force-pushed the IBX-241-Subitems-priority-buttons-hidden-behind-most-right-column branch from 2acbee9 to 4b5c2c1 Compare May 14, 2021 11:30
@lucasOsti lucasOsti changed the base branch from 2.3 to 2.2 May 14, 2021 11:30
@piotrbisaga
Copy link
Contributor

QA approved.
Check on both Ibexa Commerce 3.2 & 3.3, safari, chrome and mozilla tested.

@lucasOsti lucasOsti force-pushed the IBX-241-Subitems-priority-buttons-hidden-behind-most-right-column branch from 4b5c2c1 to f5110e7 Compare May 14, 2021 13:59
@adamwojs adamwojs merged commit f348647 into ezsystems:2.2 May 17, 2021
@adamwojs
Copy link
Member

Could you please merge up changes @lucasOsti ?

@lucasOsti
Copy link
Contributor Author

Could you please merge up changes @lucasOsti ?

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

Assignees

@piotrbisaga piotrbisaga

Labels
Bug QA approved
Milestone
No milestone
6 participants
@lucasOsti @micszo @piotrbisaga @adamwojs @tischsoic @dew326