Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-380: Cannot deselect the subtree in Admin -> Roles #1757

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-380
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

id="role_assignment_create_locations_select_content"
data-input-selector="#{{ form.locations.vars.id }}"
data-udw-config="{{ ez_udw_config('multiple', {}) }}"
class="btn btn-secondary ez-btn--select-subtree"{% if not form.limitation_type.location.vars.checked %} disabled{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if is outside of the classes, shouldn't be in the next line?

@lucasOsti lucasOsti requested a review from dew326 May 18, 2021 07:24
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA - Approved. Tested on v3.2.7.

@dew326 dew326 merged commit e65e7c4 into ezsystems:2.2 May 21, 2021
@dew326
Copy link
Member

dew326 commented May 21, 2021

@lucasOsti can you merge it up?

@lucasOsti
Copy link
Contributor Author

@lucasOsti can you merge it up?

done

@lucasOsti lucasOsti deleted the IBX-380-deselect-items-subtree-admin-limitations branch May 21, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants