Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-385: Fixed error handling when composer files are corrupted #1758

Merged
merged 1 commit into from
May 28, 2021
Merged

IBX-385: Fixed error handling when composer files are corrupted #1758

merged 1 commit into from
May 28, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented May 21, 2021 •
edited

Question Answer
Tickets IBX-385
Bug fix? no
New feature? kinda (improvement)
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Currently, whenever composer.json or composer.lock files get accidentally corrupted, the system will return exceptions coming from ez-support-tools (where those files are parsed) which results in the system being unusable. The idea is to show some warnings in:

  • the dashboard,
  • the System Information tab,
  • ez-support-tools:dump-info
    if the composer files are either not accessible or don't contain valid data.

Given, we moved AdminUI part to ez-support-tools in v3, these changes won't be needed.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza self-assigned this May 21, 2021
@konradoboza konradoboza mentioned this pull request May 21, 2021
Merged
1 task
@konradoboza konradoboza removed their assignment May 25, 2021
@bogusez bogusez self-assigned this May 27, 2021
@lserwatka lserwatka merged commit 382b365 into 1.5 May 28, 2021
@lserwatka lserwatka deleted the ibx-385-responsiveness-if-composer-files-corrupted branch May 28, 2021 10:58
@lserwatka
Copy link
Member

You can merge it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

@ViniTou ViniTou ViniTou approved these changes

@bogusez bogusez bogusez approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@bogusez bogusez

Labels
Improvement QA approved
Milestone
No milestone
7 participants
@konradoboza @lserwatka @adamwojs @alongosz @ciastektk @ViniTou @bogusez