Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32333: Hidden duplicated 'change password' menu item #1759

Merged
merged 1 commit into from
May 25, 2021
Merged

EZP-32333: Hidden duplicated 'change password' menu item #1759

merged 1 commit into from
May 25, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented May 21, 2021 •
edited

Question Answer
Tickets EZP-32333
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This fragment is not needed here as this menu item is generated in ezplatform-user package nevertheless: https://github.com/ezsystems/ezplatform-user/blob/1.0/src/lib/EventListener/UserMenuListener.php#L49

Related ezplatform-user PR: ezsystems/ezplatform-user#92

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this May 21, 2021
@barw4 barw4 mentioned this pull request May 21, 2021
Merged
1 task
@barw4 barw4 changed the title EZP-32333: Hidden 'change password' menu item if user has no access EZP-32333: Hidden duplicated 'change password' menu item May 21, 2021
@barw4 barw4 requested a review from a team May 21, 2021 18:28
ViniTou
ViniTou approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remeber when merging up, that UserMenuListener is no longer in ezplatform-user, and it was moved back to adminUI (and as I see now, it should be removed and that functionality should be restored in UserMenuBuilder).

@ViniTou ViniTou requested a review from a team May 24, 2021 07:03
kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA - Approved. Tested on 2.5.18

@adamwojs adamwojs merged commit 372973e into 1.5 May 25, 2021
@adamwojs adamwojs deleted the ezp-32333-hide-change-password-if-forbidden branch May 25, 2021 09:10
@adamwojs
Copy link
Member

Could you please merge up changes @barw4 ?

@barw4
Copy link
Member Author

barw4 commented May 25, 2021 •
edited

Merged into:
2.2: d30d627
2.3: 6d9a1aa
master: b16310d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ViniTou ViniTou ViniTou approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

Assignees

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
4 participants
@barw4 @adamwojs @ViniTou @kacper-wieczorek-ibexa