IBX-418: Skipped content name retrieve for the top node #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
requested review from
adamwojs,
Steveb-p,
alongosz,
webhdx and
ViniTou
mateuszbieniek
changed the title
adamwojs
changed the title
adamwojs
reviewed
May 24, 2021
Co-authored-by: Adam Wójs <adam@wojs.pl>
adamwojs
approved these changes
May 25, 2021
ViniTou
approved these changes
May 25, 2021
mikadamczyk
approved these changes
May 25, 2021
ciastektk
approved these changes
May 25, 2021
webhdx
approved these changes
May 25, 2021
Steveb-p
approved these changes
May 25, 2021
alongosz
approved these changes
May 25, 2021
konradoboza
approved these changes
May 25, 2021
mateuszdebinski
approved these changes
May 25, 2021
barw4
approved these changes
May 25, 2021
bogusez
approved these changes
May 26, 2021
|
Could you please merge up changes @mateuszbieniek? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tree View in UDW creates a node for the top location, which does not have content (
contentId === 0).This fix skips the content name retrieval for this node to avoid errors.
Checklist:
$ composer fix-cs)