Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-186: The top button of side menus gets hidden at the bottom of the page (mergeup fix) #1765

Merged
merged 1 commit into from
May 31, 2021
Merged

IBX-186: The top button of side menus gets hidden at the bottom of the page (mergeup fix) #1765

merged 1 commit into from
May 31, 2021

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented May 31, 2021 •
edited

Question Answer
Tickets IBX-186
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Without it initial height isn't set, only after resizing/scrolling

Checklist:

  • Ready for Code Review

kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qa Approved - Tested on 3.3.3-dev content, experience.

@lserwatka lserwatka merged commit 45e445c into 2.3 May 31, 2021
@lserwatka lserwatka deleted the IBX-186-mergeup-fix branch May 31, 2021 16:52
@lserwatka
Copy link
Member

You can merge it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
5 participants
@GrabowskiM @lserwatka @tischsoic @dew326 @kacper-wieczorek-ibexa