IBX-426: Created additional UDW config for adding Location to Content #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
reviewed
Jun 14, 2021
| @@ -105,7 +105,7 @@ | |||
|
|
|||
| {% macro table_header_tools(form_add, form_remove, can_add) %} | |||
| <button | |||
| data-udw-config="{{ ez_udw_config('single', {}) }}" | |||
| data-udw-config="{{ ez_udw_config('add_location', {}) }}" | |||
There was a problem hiding this comment.
I'm not sure about this one. @Nattfarinn correct me if I'm wrong but changing config name here is a BC break in case someone already used custom configuration for single.
There was a problem hiding this comment.
There is a tiny risk of bahavioral BC here, but I wouldn't bother much with it. I don't think anyone ever would change our generic single configuration to be anything else but multiple: false (and even if he did we don't change configuration itself [big BC], but configuration key used just for this use-case).
|
Could you please rebase PR against current 2.2 branch? This should fix issues reporeted by CI. |
Steveb-p
reviewed
Jun 14, 2021
Steveb-p
approved these changes
Jun 14, 2021
Nattfarinn
approved these changes
Jun 15, 2021
micszo
approved these changes
Jun 16, 2021
|
You can merge it up now. |
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add locationaction should not take into account anycontent/createrestrictions, it should allow every content to be used as a destination if the user cancontent/readit.Checklist:
$ composer fix-cs)