Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32387: Fixed text block toolbar alignment #1778

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Jun 10, 2021

Question Answer
Tickets EZP-32387
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

JIRA excerpt:

When editing a Page Builder, the Rich text inside a Text block is unconfortable to use in certain cases. Sometimes, impossible to use. When you click on align right on the toolbar inside the Text Block, the toolbar aligns itself to the right as well. But the toolbar collapses and a part of it is hidden. Also a scrollbar appears on the bottom of the window, but impossible to scroll.

Steps to reproduce:

  1. Install a clean version of Ibexa V.3.3
  2. Edit a landing page
  3. Add a text bloc inside the landing page(drag and drop)
  4. click on the content block of the Text Block and see the toolbar appears
  5. click on align right button
  6. You will notice that a part of the toolbar is missing and the window has a scrollbar on its bottom. Try to use that scrollbar. You cannot.

PR for 3.x (targetting ezplatform-richtext) will be created once this solution is approved.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza
Copy link
Member Author

konradoboza commented Jun 10, 2021

After internal sync with @dew326 we decided to introduce this change also in the default RTE view.

@konradoboza konradoboza removed their assignment Jun 10, 2021
@bogusez bogusez self-assigned this Jun 11, 2021
@lserwatka lserwatka merged commit 479e946 into 1.5 Jun 14, 2021
@lserwatka lserwatka deleted the ezp-32387-pb-block-toolbar-alignment branch June 14, 2021 11:09
@lserwatka
Copy link
Member

You can merge it up now.

@konradoboza
Copy link
Member Author

Done in:
2.3: 4be0503,
master: 337ee28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants